-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build installers at the end of the repo build and allow building with desktop msbuild #58987
Open
ViktorHofer
wants to merge
3
commits into
main
Choose a base branch
from
BuildInstallersAtTheEndOfTheRepoBuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Nov 15, 2024
ViktorHofer
added
the
* NO MERGE *
Do not merge this PR as long as this label is present.
label
Nov 15, 2024
Adding the NO MERGE label until I fully tested the changes inside the VMR |
ViktorHofer
force-pushed
the
BuildInstallersAtTheEndOfTheRepoBuild
branch
from
November 15, 2024 16:02
4de0a68
to
acd5702
Compare
Local Development job failures are unrelated |
ViktorHofer
force-pushed
the
BuildInstallersAtTheEndOfTheRepoBuild
branch
from
November 20, 2024 19:17
70c81d9
to
31975d7
Compare
Build the Installer projects after everythign else got built by adding a new Traversal project that builds all P2Ps in it in parallel. Fixes #58984 Unblocks dotnet/sdk#44828
ViktorHofer
force-pushed
the
BuildInstallersAtTheEndOfTheRepoBuild
branch
from
November 21, 2024 12:04
ec997da
to
1504eaf
Compare
ViktorHofer
changed the title
Build installers at the end of the repo build
Build installers at the end of the repo build and allow building with desktop msbuild
Nov 21, 2024
@ellahathaway this will fix the Sign and Publish issue as well inside the VMR. |
ViktorHofer
force-pushed
the
BuildInstallersAtTheEndOfTheRepoBuild
branch
4 times, most recently
from
November 21, 2024 17:06
1eb05c2
to
10a83ad
Compare
ViktorHofer
force-pushed
the
BuildInstallersAtTheEndOfTheRepoBuild
branch
8 times, most recently
from
November 21, 2024 23:45
de2791e
to
b98ec78
Compare
ViktorHofer
force-pushed
the
BuildInstallersAtTheEndOfTheRepoBuild
branch
from
November 22, 2024 00:10
b98ec78
to
41c4084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
* NO MERGE *
Do not merge this PR as long as this label is present.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the Installer projects after everythign else got built by adding a new Traversal project that
builds all P2Ps in it in parallel.
Fixes #58984 Unblocks dotnet/sdk#44828
{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)