Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dotnet-format pre commit hook. #27712

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Added dotnet-format pre commit hook. #27712

merged 1 commit into from
Jan 19, 2021

Conversation

ShreyasJejurkar
Copy link
Contributor

Regarding #27632

Summary of the changes (Less than 80 chars)

  • Added pre-commit hook to format changed source files.
  • Added code to build script to check dotnet-format tool installation.
  • Configure default git hooks directory to .githooks to version and track hooks.

As part of #27380 & #27609

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 11, 2020
@javiercn
Copy link
Member

@MCCshreyas thanks for your contribution!

The changes look great!

I'll give a heads up to other folks on the team so that they don't get surprised by this and we'll merge it in the following days.

@javiercn javiercn added the community-contribution Indicates that the PR has been added by a community member label Jan 19, 2021
@ShreyasJejurkar
Copy link
Contributor Author

Thanks @javiercn! 🙌

@javiercn javiercn merged commit eadca9d into dotnet:master Jan 19, 2021
@ryanbrandenburg ryanbrandenburg mentioned this pull request Jan 21, 2021
Merged
@halter73 halter73 mentioned this pull request Jan 22, 2021
Closed
@ShreyasJejurkar ShreyasJejurkar deleted the pre-commit-hook branch April 13, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

Assignees

@javiercn javiercn

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShreyasJejurkar @javiercn @mkArtakMSFT