Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix IIS outofprocess to remove WebSocket compression handshake #58931

Open
wants to merge 7 commits into
base: release/9.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 13, 2024

Backport of #58846 to release/9.0

/cc @BrennanConroy

Fix IIS outofprocess to remove WebSocket compression handshake

Description

Blazor enabled websocket compression by default in some cases. IIS OutOfProcess is a hosting model some customers use and it is not compatible with websocket compression.

Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/2688

Customer Impact

Using IIS OutOfProcess with Blazor Server-side/Interactive will not work.

Regression?

  • Yes
  • No

Regression from 8.0

Risk

  • High
  • Medium
  • Low

Added automated testing and did manual testing. Fix is fairly simple change.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 13, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Nov 13, 2024
@BrennanConroy BrennanConroy added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Nov 13, 2024
@BrennanConroy BrennanConroy added Servicing-approved Shiproom has approved the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Nov 14, 2024
Copy link
Contributor

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant