-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hook with code formatting #58965
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
Thanks for your PR, @nazolek. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Thanks for the change! Looks like the original blocking issue has been fixed, and this does solve the build.sh problem - @SteveSandersonMS, any concerns with this approach? |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- .githooks/pre-commit: Language not supported
- eng/build.ps1: Language not supported
- eng/build.sh: Language not supported
Add pre-commit hook with code formatter under the hood
In the context of PR, trying to solve an issue related to file formatting during pre-commit hook.
Description
The issue #30145 outlines the backward of the previous approach and why it was reverted. Based on that, wanna suggest some improvements:
Fixes #27632