Skip to content

Build "Windows Local Development" job in official builds #61519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 16, 2025

Allows us to build our templates in the internal project, so that they can be tracked by CG. Fixes #61518.

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2688844&view=results

@wtgodbe wtgodbe requested a review from a team as a code owner April 16, 2025 17:57
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 16, 2025
Copy link
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe requested a review from Copilot April 18, 2025 17:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Windows Local Development job to the official builds to enable building templates in the internal project and tracking them via CG. The key changes include updating the build step to use a PowerShell script instead of a CMD script and adding additional build parameters.

  • Replaces build.cmd with build.ps1 and adds the "-WarnAsError:false" flag.
  • Adds the "-bl" argument to the test execution block.
Comments suppressed due to low confidence (2)

.azure/pipelines/ci.yml:661

  • [nitpick] The purpose of the '-bl' flag is not immediately clear. Consider adding an inline comment or using a more descriptive flag name to clarify its intent.
                      -bl

.azure/pipelines/ci.yml:647

  • The new build step uses a PowerShell script with a quoted argument '-WarnAsError:false'. Please verify that the quotes are required and that the script correctly interprets the flag. If the script expects a boolean value, consider passing it without quotes or using an assignment format (for example, -WarnAsError=$false).
            - powershell: ./eng/build.ps1 -all -noBuildJava -noBuildNodeJS "-WarnAsError:false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build templates in internal builds
1 participant