RFC: Add runAsDaemon option to UseHost #1243
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WeihanLi
reviewed
Aug 29, 2023
| if (runAsDaemon) | ||
| { | ||
| await next(invocation); | ||
| await host.RunAsync(); |
There was a problem hiding this comment.
Maybe better using the cancellation token from the invocationContext so that we could graceful stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my own project I wanted to start Asp.Net server from command line.
I also wanted to bind parsed CLI arguments into my option by
BindCommandLine(), So I had to useUseHost(), which does not support runningIHostforever and instead stops right after the startup.I ended up re-writing my own commandline middleware which is mostly the same with
UseHost,but with one difference that it invokeshost.RunAsync()instead ofhost.StartAsync().So I thought it would be better to have this feature built in to this library.
Please don't merge yet, this PR has no test. I'm not even sure this is the right way to achieve my goal (I'm not super familiar to dotnet itself either).
Any feedback is welcome.