Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #2140

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Misc fixes #2140

merged 5 commits into from
Nov 21, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Nov 21, 2024 •
edited by github-actions bot
Loading

Summary

  • Fix what appears to be a bad merge conflict.
  • Fix dup word.
  • Fix breadcrumbs to the best of the platform supported capabilities.

Fixes #2133 and maybe #2099

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/authentication/keycloak-integration.md .NET Aspire Keycloak integration
docs/azureai/azureai-openai-integration.md .NET Aspire Azure OpenAI integration
docs/azureai/azureai-search-document-integration.md .NET Aspire Azure AI Search Documents integration
docs/community-toolkit/hosting-data-api-builder.md Community Toolkit Azure Data API Builder hosting integration
docs/database/azure-cosmos-db-entity-framework-integration.md docs/database/azure-cosmos-db-entity-framework-integration
docs/database/azure-cosmos-db-integration.md .NET Aspire Azure Cosmos DB integration
docs/database/milvus-integration.md .NET Aspire Milvus database integration
docs/database/mongodb-integration.md .NET Aspire MongoDB database integration
docs/database/oracle-entity-framework-integration.md docs/database/oracle-entity-framework-integration
docs/database/qdrant-integration.md .NET Aspire Qdrant integration
docs/fundamentals/dashboard/security-considerations.md .NET Aspire dashboard security considerations
docs/get-started/build-aspire-apps-with-nodejs.md Orchestrate Node.js apps in .NET Aspire
docs/logging/seq-integration.md .NET Aspire Seq integration
docs/messaging/azure-event-hubs-integration.md docs/messaging/azure-event-hubs-integration
docs/messaging/azure-service-bus-integration.md .NET Aspire Azure Service Bus integration
docs/messaging/azure-web-pubsub-integration.md .NET Aspire Azure Web PubSub integration
docs/search/elasticsearch-integration.md .NET Aspire Elasticsearch integration
docs/security/azure-security-key-vault-integration.md docs/security/azure-security-key-vault-integration
docs/storage/azure-storage-blobs-integration.md .NET Aspire Azure Blob Storage integration
docs/storage/azure-storage-queues-integration.md .NET Aspire Azure Queue Storage integration
docs/storage/azure-storage-tables-integration.md .NET Aspire Azure Data Tables integration

@dotnetrepoman dotnetrepoman bot added caching Content related to caching. database Content related to database. fundamentals Content related to fundamentals. messaging Content related to messaging. security Content related to security. storage Content related to storage. labels Nov 21, 2024
@IEvangelist IEvangelist requested a review from gewarren November 21, 2024 01:41
@dotnet-policy-service dotnet-policy-service bot added okr-health okr-quality Content-health KR: Concerns article defects/freshness or build warnings. labels Nov 21, 2024
@IEvangelist IEvangelist enabled auto-merge (squash) November 21, 2024 01:59
BillWagner
BillWagner approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM. Let's :shipit:

@IEvangelist IEvangelist merged commit ddd3be1 into dotnet:main Nov 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@gewarren gewarren Awaiting requested review from gewarren

Assignees
No one assigned
Labels
caching Content related to caching. database Content related to database. fundamentals Content related to fundamentals. messaging Content related to messaging. :octocat: auto-merge okr-health okr-quality Content-health KR: Concerns article defects/freshness or build warnings. security Content related to security. storage Content related to storage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duplicate word typo
2 participants
@IEvangelist @BillWagner