Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more links to MSTest api docs #44716

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Add more links to MSTest api docs #44716

merged 8 commits into from
Feb 10, 2025

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Feb 7, 2025 •
edited by github-actions bot
Loading

@Evangelink Evangelink requested review from IEvangelist and a team as code owners February 7, 2025 14:18
@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 7, 2025
@BillWagner BillWagner requested a review from gewarren February 7, 2025 15:15
@BillWagner
Copy link
Member

Adding @gewarren

Do you know why the xrefs are generating warnings here?

@gewarren
Copy link
Contributor

gewarren commented Feb 7, 2025

BTW, we have an extension for VS Code that inserts xrefs links. Do you know about it? It's a very helpful tool. https://github.com/IEvangelist/xref-helper/blob/main/README.md

@Evangelink
Copy link
Member Author

BTW, we have an extension for VS Code that inserts xrefs links. Do you know about it? It's a very helpful tool. IEvangelist/xref-helper@main/README.md

I wasn't aware of it!

gewarren
gewarren approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments - but these are only suggestions that you can decide for yourself about.

@Evangelink Evangelink closed this Feb 10, 2025
@Evangelink Evangelink deleted the mstest-apis branch February 10, 2025 08:19
@Evangelink Evangelink restored the mstest-apis branch February 10, 2025 09:33
@Evangelink
Copy link
Member Author

Sorry I deleted the wrong branch...

@Evangelink Evangelink reopened this Feb 10, 2025
@Evangelink
Copy link
Member Author

@gewarren this should now be ready for the final review, thanks <3

@Evangelink @gewarren
Apply suggestions from code review
34f857e 
Co-authored-by: Genevieve Warren <[email protected]>
@Evangelink Evangelink enabled auto-merge (squash) February 10, 2025 19:14
@Evangelink
Copy link
Member Author

Thank you @gewarren 🙇

@Evangelink Evangelink merged commit fe82d34 into dotnet:main Feb 10, 2025
8 checks passed
@Evangelink Evangelink deleted the mstest-apis branch February 19, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@gewarren gewarren gewarren approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@Evangelink @BillWagner @gewarren @Youssef1313