Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes related to automated cleanrepo runs #45595

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Fixes related to automated cleanrepo runs #45595

merged 1 commit into from
Apr 2, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 1, 2025 •
edited by github-actions bot
Loading

  • Add new unit testing article to TOC (please check locations @Youssef1313)
    • Also some style guide improvements to this article
  • Fix workflow inputs for remove redirect hops

Internal previews

📄 File 🔗 Preview link
.github/workflows/cleanrepo-redirect-hops.yml .github/workflows/cleanrepo-redirect-hops
docs/core/testing/unit-testing-with-dotnet-test.md Testing with 'dotnet test'
docs/navigate/devops-testing/toc.yml docs/navigate/devops-testing/toc

@gewarren gewarren requested review from IEvangelist and a team as code owners April 1, 2025 23:50
@dotnetrepoman dotnetrepoman bot added this to the April 2025 milestone Apr 1, 2025
Youssef1313
Youssef1313 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BillWagner
BillWagner approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM @gewarren

@gewarren gewarren merged commit 0b599c2 into dotnet:main Apr 2, 2025
10 checks passed
@gewarren gewarren deleted the misc-0401 branch April 2, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@gewarren @BillWagner @Youssef1313