Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PKCE support to OAuth2 flow #100

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

halilkocaoz
Copy link
Contributor

@halilkocaoz halilkocaoz commented Nov 18, 2023

There was a TODO line for implementing Authorization Code flow with PKCE on security definition.

@davidfowl
Copy link
Member

Did you test it?

@halilkocaoz
Copy link
Contributor Author

halilkocaoz commented Nov 19, 2023

Sorry for miss-implementing, could you review again? @davidfowl

I added CORS policy for any origins. Should CORS policy be just for these: builder.Configuration["BasketApiClient"], builder.Configuration["OrderingApiClient"], builder.Configuration["WebhooksWebClient"], builder.Configuration["WebhooksApiClient"], builder.Configuration["WebAppClient"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants