Fall back to loading .NET 8 date strings #26033
Open
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
the
area-essentials
Foda
previously approved these changes
Nov 21, 2024
jsuarezruiz
previously approved these changes
Nov 22, 2024
bronteq
reviewed
Nov 22, 2024
PureWeen
requested changes
Nov 23, 2024
PureWeen
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This has to do with the different implementations of the preferences API on Windows depending on packaged or unpackaged.
The implementation differs:
The real change comes in at #22815 where that PR had this line: https://github.com/dotnet/maui/pull/22815/files#diff-6ed591e38dc7754551705bf5bb96f992115c384d19166e8dcda76267e177fb0cR196-R197
In .NET 8 everything was a "ToString" system for unpackaged. In .NET 9 there is now a ToBinary.
Issues Fixed
Fixes #25930