Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Legacy Gallery from SLNs #26068

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Remove Legacy Gallery from SLNs #26068

merged 1 commit into from
Nov 26, 2024

Conversation

PureWeen
Copy link
Member

Description of Change

We're not longer using the Legacy Galleries so let's remove them from our SLNs. This should help load and build times a bit.

I moved the CG SLNF to a full SLN just in case we want to run the Legacy CGs at a later point in time. Ideally we will just delete all this code for net10 or later this year

@PureWeen PureWeen requested a review from a team as a code owner November 22, 2024 15:46
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also need to update scripts removing the legacy gallery. For example:

["Compatibility.ControlGallery.Android"] = "Compatibility.ControlGallery.Android",

or
Task("dotnet-legacy-controlgallery-ios")

And from the pipelines:

compatibilityAndroidApp: $(System.DefaultWorkingDirectory)/src/Compatibility/ControlGallery/src/Android/Compatibility.ControlGallery.Android.csproj

@jfversluis jfversluis dismissed jsuarezruiz’s stale review November 26, 2024 10:17

Lets merge this first, then we can still run the pipelines if we want/need. For now removing from SLN will reduce the load for people opening this on their machines.

@jfversluis jfversluis merged commit 6c2ec20 into main Nov 26, 2024
104 checks passed
@jfversluis jfversluis deleted the remove_cg_from_slns branch November 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants