Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Hide/show titlebar on modal pages #26071

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

Foda
Copy link
Member

@Foda Foda commented Nov 22, 2024

Description of Change

Toggle the titlebar visibility when modal pages are pushed/popped.

Issues Fixed

Fixes #25964

@Foda Foda requested a review from a team as a code owner November 22, 2024 20:10
PureWeen
PureWeen previously approved these changes Nov 22, 2024
@PureWeen
Copy link
Member

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11981567160

@mattleibow
Copy link
Member

Can we get tests for this one?

@PureWeen
Copy link
Member

Can we get tests for this one?

we could probably validate the raw control.
The screen shot tests don't work because we cut off the titlebar so we can use screen comparison tests :-/

We're going to add a manual test as well here for validation

@jsuarezruiz
Copy link
Contributor

Can we get tests for this one?

Can we get tests for this one?

we could probably validate the raw control. The screen shot tests don't work because we cut off the titlebar so we can use screen comparison tests :-/

We're going to add a manual test as well here for validation

We could maybe manage the cutting logic, to avoid it when necessary. But, yeah, with a Device Test should be enough.


if (windowManager.RootView is WindowRootView wrv)
// Hide titlebar on previous page
var previousContext = previousPage.FindMauiContext();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure -- lemme add that to the existing modal push/pop Windows tests

@jfversluis jfversluis merged commit 2c08a0d into main Nov 26, 2024
104 checks passed
@jfversluis jfversluis deleted the foda/TitlebarModal branch November 26, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[WinUI] App TitleBar overlapping on .NET9 when using Modals
5 participants