-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Hide/show titlebar on modal pages #26071
Conversation
/backport to release/9.0.1xx |
Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11981567160 |
Can we get tests for this one? |
we could probably validate the raw control. We're going to add a manual test as well here for validation |
We could maybe manage the cutting logic, to avoid it when necessary. But, yeah, with a Device Test should be enough. |
|
||
if (windowManager.RootView is WindowRootView wrv) | ||
// Hide titlebar on previous page | ||
var previousContext = previousPage.FindMauiContext(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include a device test? https://github.com/dotnet/maui/tree/main/src/Controls/tests/DeviceTests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure -- lemme add that to the existing modal push/pop Windows tests
Description of Change
Toggle the titlebar visibility when modal pages are pushed/popped.
Issues Fixed
Fixes #25964