Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Roslyn LSP library instead of Visual Studio #10682

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Use Roslyn LSP library instead of Visual Studio #10682

wants to merge 23 commits into from

Commits on Jul 30, 2024

  1. Rename VsLsp files to just Lsp 

    I'm assuming the Vs versions of these are more complete than the Roslyn ones
    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    95c37af View commit details
    Browse the repository at this point in the history

  2. Remote RoslynLsp files

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a9ab067 View commit details
    Browse the repository at this point in the history

  3. Rename VsLsp* and RoslynLsp* to just Lsp* 

    This commit done entirely via Replace In Files
    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b0dcedb View commit details
    Browse the repository at this point in the history

  4. Change all Range aliases to LspRange aliases 

    This is to make things easier in future, as we'll be getting a global using for all protocol types
    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    27c038c View commit details
    Browse the repository at this point in the history

  5. Reference Roslyn protocol library, and deal with the extern alias bits

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4c649b2 View commit details
    Browse the repository at this point in the history

  6. Remove unused usings 

    Not a mechanical commit, but my word is it doing a good job cosplaying as one
    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    eb3565c View commit details
    Browse the repository at this point in the history

  7. More Range -> LspRange

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9792de5 View commit details
    Browse the repository at this point in the history

  8. Introduce extern alias where necessary to reference Roslyn types

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8d45e98 View commit details
    Browse the repository at this point in the history

  9. Move Lsp helpers into the right namespace

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bbb5adb View commit details
    Browse the repository at this point in the history

  10. Adjust namespaces and factory method names

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e4537e0 View commit details
    Browse the repository at this point in the history

  11. Adjust visibility on a couple of things

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6067779 View commit details
    Browse the repository at this point in the history

  12. Fix issues with ContainedLanguage being dependent on VS types

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    be5f735 View commit details
    Browse the repository at this point in the history

  13. Roslyn types are immutable

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a21fd27 View commit details
    Browse the repository at this point in the history

  14. Cohost signature help now only has to return a single type

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8725bba View commit details
    Browse the repository at this point in the history

  15. Project file tweaks

    @davidwengier
    davidwengier committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bd720ba View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. PR feedback

    @davidwengier
    davidwengier committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7caf726 View commit details
    Browse the repository at this point in the history

  2. Use extension method as extension method

    @davidwengier
    davidwengier committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ccd76da View commit details
    Browse the repository at this point in the history

  3. Move test code back to the test where it belongs

    @davidwengier
    davidwengier committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f505e9c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into LspTypes

    @davidwengier
    davidwengier committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1d5a102 View commit details
    Browse the repository at this point in the history

  5. Fixes after merge

    @davidwengier
    davidwengier committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e572122 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge remote-tracking branch 'upstream/main' into LspTypes

    @davidwengier
    davidwengier committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4ca0fbe View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge remote-tracking branch 'upstream/main' into LspTypes 

    # Conflicts:
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/AutoInsert/IOnAutoInsertProvider.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/AutoInsert/PreferHtmlInAttributeValuesDocumentPositionStrategy.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/AddUsingsCodeActionProviderHelper.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Razor/AddUsingsCodeActionResolver.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Razor/GenerateMethodCodeActionResolver.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/ColorPresentation/ColorPresentationEndpoint.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DefaultDocumentPositionInfoStrategy.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Definition/DefinitionEndpoint.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DocumentColor/DocumentColorEndpoint.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DocumentColor/DocumentColorService.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DocumentColor/IDocumentColorService.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentFormattingEndpoint.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentRangeFormattingEndpoint.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/FormattingContentValidationPass.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/FormattingOptionsExtensions.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/FormattingPassBase.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/FormattingResult.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/IRazorFormattingService.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/RazorFormattingService.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/IDocumentPositionInfoStrategy.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/InlayHints/IInlayHintService.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/InlayHints/InlayHintService.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/PreferAttributeNameDocumentPositionInfoStrategy.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/SpellCheck/DocumentSpellCheckEndpoint.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInsert/AutoClosingTagOnAutoInsertProvider.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInsert/CloseTextTagOnAutoInsertProvider.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/LspExtensions_SyntaxNode.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/LspFactory.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/RoslynLspExtensions_SourceText.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/RoslynLspFactory.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/CSharpFormatter.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/CSharpFormattingPassBase.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/CSharpOnTypeFormattingPass.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/FormattingDiagnosticValidationPass.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/RazorFormattingPass.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/VersionedDocumentContext.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Protocol/SemanticTokens/ProvideSemanticTokensRangesParams.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Debugging/IRazorBreakpointResolver.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostSignatureHelpEndpoint.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Debugging/DefaultLSPBreakpointSpanProvider.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Debugging/DefaultLSPProximityExpressionsProvider.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Debugging/DefaultRazorBreakpointResolver.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Debugging/DefaultRazorProximityExpressionResolver.cs
#	src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Debugging/LSPBreakpointSpanProvider.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/AutoInsert/OnAutoInsertEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/AutoInsert/RazorOnAutoInsertProviderTestBase.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/CodeActions/CSharp/DefaultCSharpCodeActionResolverTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/CodeActions/CodeActionEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/CodeActions/Html/DefaultHtmlCodeActionProviderTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Debugging/RazorBreakpointSpanEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Debugging/RazorProximityExpressionsEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Definition/DefinitionEndpointDelegationTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Definition/DefinitionEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/DocumentPresentation/TextDocumentTextPresentationEndpointTests.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/DocumentPresentation/TextDocumentUriPresentationEndpointTests.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/DocumentOnTypeFormattingEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingContentValidationPassTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingDiagnosticValidationPassTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingLanguageServerClient.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingLanguageServerTestBase.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/RazorFormattingServiceTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Hover/HoverServiceTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Mapping/RazorMapToDocumentRangesEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Refactoring/RenameEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/SingleServerDelegatingEndpointTestBase.TestLanguageServer.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/WrapWithTag/WrapWithTagEndpointTests.cs
#	src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/LanguageClient/Debugging/RazorBreakpointResolverTest.cs
#	src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/LanguageClient/Debugging/TestLSPBreakpointSpanProvider.cs
#	src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/RazorLanguageService_IVsLanguageDebugInfoTest.cs
    @davidwengier
    davidwengier committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ef3b749 View commit details
    Browse the repository at this point in the history

  2. Fixes after merge

    @davidwengier
    davidwengier committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dd43a04 View commit details
    Browse the repository at this point in the history