Completion resolve endpoint skeleton #11226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Making the resolve completion use document for cohosting - Serializing TextDocument property into Data member of completion items so that Roslyn will forward the request to us - Basic sanity test (shows we are getting called now)
|
This feels like a commit that should be part of a larger PR, not a PR itself. I don't think we should be diverging the normal and cohosting endpoints like this, as that is how bugs creep in. Additionally, I can't see how there won't have to be changes to the completion resolve service in light of this change, and trying to review those changes separately in another PR will just be harder, with a complete lack of context. |
ryzngard
added a commit
to dotnet/vscode-csharp
that referenced
this pull request
Nov 20, 2024
Extension side of dotnet/razor#11226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes:
Partial fix for #11101