Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parameters for CA1864 #6826

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

CollinAlpert
Copy link
Contributor

CA1864 now also triggers if the value argument passed to the Add method is a parameter.

Fixes #6824

@CollinAlpert CollinAlpert requested a review from a team as a code owner August 1, 2023 09:05
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #6826 (89670a4) into main (48e7c8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6826   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files        1401     1401           
  Lines      329956   330008   +52     
  Branches    10837    10837           
=======================================
+ Hits       317968   318022   +54     
+ Misses       9256     9254    -2     
  Partials     2732     2732           

@mavasani mavasani merged commit 0855981 into dotnet:main Aug 1, 2023
11 checks passed
@CollinAlpert CollinAlpert deleted the issue_6824 branch August 1, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative with CA1856
2 participants