Skip to content

Commit

Permalink
Fix CET - remove writing to shadow stack (#103171)
Browse files Browse the repository at this point in the history
In my recent fix for failures with CET enabled, I have also added a call to
the _wrssq intrinsic to push an address to shadow stack. It turns out
that instruction is privileged and cannot be used by user code.
Moreover, I have realized that it is not needed at all there, so I am
removing it.

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny,cz>
  • Loading branch information
janvorli and Jan Vorlicek authored Jun 8, 2024
1 parent 2da65a9 commit 39ecbe0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/coreclr/vm/exceptionhandling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7865,7 +7865,6 @@ extern "C" void * QCALLTYPE CallCatchFunclet(QCall::ObjectHandleOnStack exceptio
if (targetSSP != 0)
{
targetSSP -= sizeof(size_t);
_wrssq(pvRegDisplay->pCurrentContext->Rip, (void*)targetSSP);
}
#endif // HOST_WINDOWS
#elif defined(HOST_X86)
Expand Down

0 comments on commit 39ecbe0

Please sign in to comment.