Fix regression in constructor parameter binding logic. (#109786)

dotnet · Nov 14, 2024 · d3f4de1 · d3f4de1
1 parent 1c4c009
commit d3f4de1
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
@@ -1209,7 +1209,8 @@ internal void ConfigureConstructorParameters()
                     continue;
                 }
 
-                ParameterLookupKey paramKey = new(propertyInfo.PropertyType, propertyInfo.Name);
+                string propertyName = propertyInfo.MemberName ?? propertyInfo.Name;
+                ParameterLookupKey paramKey = new(propertyInfo.PropertyType, propertyName);
                 if (!parameterIndex.TryAdd(paramKey, parameterInfo))
                 {
                     // Multiple object properties cannot bind to the same constructor parameter.

diff --git a/...ries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs b/...ries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
@@ -1668,5 +1668,32 @@ public async Task RespectRequiredConstructorParameters_NoParameterMissing_Succee
             Assert.Equal(2, result.Y);
             Assert.Equal(3, result.Z);
         }
+
+        [Fact]
+        public async Task ClassWithConflictingCaseInsensitiveProperties_Succeeds_When_CaseSensitive()
+        {
+            // Regression test for https://github.com/dotnet/runtime/issues/109768
+
+            string json = """{"a": "lower", "A": "upper"}""";
+            ClassWithConflictingCaseInsensitiveProperties result = await Serializer.DeserializeWrapper<ClassWithConflictingCaseInsensitiveProperties>(json);
+            Assert.Equal("lower", result.From);
+            Assert.Equal("upper", result.To);
+        }
+
+        public class ClassWithConflictingCaseInsensitiveProperties
+        {
+            [JsonPropertyName("a")]
+            public string From { get; set; }
+
+            [JsonPropertyName("A")]
+            public string To { get; set; }
+
+            [JsonConstructor]
+            public ClassWithConflictingCaseInsensitiveProperties(string from, string to)
+            {
+                From = from;
+                To = to;
+            }
+        }
     }
 }
diff --git a/...Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs b/...Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs
@@ -154,6 +154,7 @@ protected ConstructorTests_Metadata(JsonSerializerWrapper stringWrapper)
         [JsonSerializable(typeof(TypeWithEnumParameters))]
         [JsonSerializable(typeof(ClassWithIgnoredPropertyDefaultParam))]
         [JsonSerializable(typeof(ClassWithCustomConverterOnCtorParameter))]
+        [JsonSerializable(typeof(ClassWithConflictingCaseInsensitiveProperties))]
         internal sealed partial class ConstructorTestsContext_Metadata : JsonSerializerContext
         {
         }
@@ -303,6 +304,7 @@ public ConstructorTests_Default(JsonSerializerWrapper jsonSerializer) : base(jso
         [JsonSerializable(typeof(TypeWithEnumParameters))]
         [JsonSerializable(typeof(ClassWithIgnoredPropertyDefaultParam))]
         [JsonSerializable(typeof(ClassWithCustomConverterOnCtorParameter))]
+        [JsonSerializable(typeof(ClassWithConflictingCaseInsensitiveProperties))]
         internal sealed partial class ConstructorTestsContext_Default : JsonSerializerContext
         {
         }