JIT: Don't run fgRenumberBlocks after switch recognition
#108402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
3 tasks
Open
3 tasks
amanasifkhalid
changed the title
fgRenumberBlocks callsfgRenumberBlocks after switch recognition
|
@dotnet/jit-contrib PTAL. No diffs -- this is moreso for clearing out my PR backlog. Thanks! |
EgorBo
approved these changes
Nov 14, 2024
|
/ba-g Build Analysis blocked by timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #108357. Since LSRA's block ordering logic no longer uses
bbNums, we shouldn't need to renumber blocks beforehand -- and since block predecessor lists are sorted based onbbID, we shouldn't incur diffs during LSRA when searching for block preds that meet certain criteria.Locally, this had small diffs due to
fgUpdateFlowGraphhaving abbNumcheck here as a proxy for detecting backward jumps. Removing this check has large diffs, though we plan to rewrite this phase as part of #107749 anyway, so I don't plan to remove this check in this PR.