-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign VN for COMMA in gtWrapWithSideEffects #108955
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
@MihuBot -dependsOn 108838 |
PTAL @AndyAyersMS @dotnet/jit-contrib using System;
using System.Runtime.CompilerServices;
class Program
{
static void Main()
{
for (int i=0; i<200; i++) {
Test();
Thread.Sleep(16);
}
}
[MethodImpl(MethodImplOptions.NoInlining)]
static int Test() => MyArray.arr[2]; // should drop bound checks, array length is known
}
class MyArray {
public static readonly int[] arr = new int[10];
} at least, it's a clean up.. |
src/coreclr/jit/gentree.cpp
Outdated
GenTree* comma = gtNewOperNode(GT_COMMA, tree->TypeGet(), sideEffects, tree); | ||
comma->gtVNPair = tree->gtVNPair; | ||
return comma; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to attach the exception set from sideEffects
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Addressed
@MihuBot -dependsOn 108838,108606 |
SPMI failures are due to JIT-EE bump in a PR merged recently |
Let's see if this works out on CI..