Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.DirectoryServices.Protocols: Force using LDAP V3 for SASL binding #109450

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

System.DirectoryServices.Protocols: Force using LDAP V3 for SASL binding #109450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35100d4
System.DirectoryServices.Protocols: Force using LDAP V3 for SASL binding
0xced Nov 1, 2024
a9ab82b
Merge branch 'main' into System.DirectoryServices.Protocols-LDAPV3
0xced Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...oryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapConnection.Linux.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ private int BindSasl()
Marshal.StructureToPtr(defaults, ptrToDefaults, false);
try
{
// Bump up the protocol version because ldap_sasl_interactive_bind requires LDAP V3 else it returns LDAP_NOT_SUPPORTED and this ends up throwing LdapException: The feature is not supported.
SessionOptions.ProtocolVersion = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-OSX, this must be working before the change above -- will this break V1\V2 users in those cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't have a Linux machine to test. I tried to setup Kerberos + OpenLDAP in Docker to test on Linux but I couldn't create a working environment.

return Interop.Ldap.ldap_sasl_interactive_bind(_ldapHandle, null, Interop.KerberosDefaultMechanism, IntPtr.Zero, IntPtr.Zero, Interop.LDAP_SASL_QUIET, LdapPal.SaslInteractionProcedure, ptrToDefaults);
}
finally
Expand Down
Loading