-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Improve containment for widening intrinsics #109474
Merged
Merged
+91
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Nov 2, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Nov 2, 2024
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Open
3 tasks
saucecontrol
commented
Nov 2, 2024
saucecontrol
commented
Nov 2, 2024
Comment on lines
-9467
to
-9468
supportsAlignedSIMDLoads = !comp->canUseVexEncoding() || !comp->opts.MinOpts(); | ||
supportsUnalignedSIMDLoads = comp->canUseVexEncoding(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions are AVX+ so they imply VEX encoding.
tannergooding
approved these changes
Nov 20, 2024
CC. @dotnet/jit-contrib for secondary review. |
BruceForstall
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds containment support for the AVX-512 integer widening loads and fixes a few problems with the existing logic. In summary, it:
Examples:
Enabled containment of scalar loads for all qualifying widening instructions
Scalar load containment was previously disabled for all widening instructions except
movddup
.Before
After
Disabled containment of scalar loads smaller than the instruction requirement
Scalar load containment was enabled unconditionally for
movddup
. This example should not be contained because it reads only 4 bytes, while the contained load will read 8.Before
After
Disabled containment of aligned loads smaller than 16 bytes in MinOpts
In MinOpts, we typically allow containment of aligned loads on non-VEX hardware because the instructions will fault on unaligned addresses, however this is not true for instructions that load smaller values. This example was previously contained with MinOpts, EnableAVX=0.
Before
After
Remaining diffs are all improvements.