-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GFNI Intrinsics #109537
Add GFNI Intrinsics #109537
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
if (((cpuFeatures & XArchIntrinsicConstants_Evex) != 0) && | ||
((cpuFeatures & XArchIntrinsicConstants_Avx10v1) != 0)) | ||
{ | ||
if (CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_EnableAVX10v1)) | ||
{ | ||
CPUCompileFlags.Set(InstructionSet_EVEX); | ||
CPUCompileFlags.Set(InstructionSet_AVX10v1); | ||
|
||
if((cpuFeatures & XArchIntrinsicConstants_Avx512) != 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check wasn't really correct because it looks only at the cpuid bit and not the config knob. However, it doesn't matter anyway because if AVX512 is disabled, AVX10v1_V512
will be removed by implication in the call to EnsureValidInstructionSetSupport
.
For simplicity and consistency with the other combo flags to come, I changed it to add the whole set as above, relying on the implications to do their job.
CC. @dotnet/jit-contrib for secondary review -- The JIT format errors are notably unrelated and are under #109987 (comment) |
Fixes #96170