-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IHttpClientLogger.cs and IHttpClientAsyncLogger.cs remarks #109618
Update IHttpClientLogger.cs and IHttpClientAsyncLogger.cs remarks #109618
Conversation
Updated IHttpClientLogger remarks to provide clearer documentation to a developer implementing this interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I believe the actual API docs still need to be updated manually in https://github.com/dotnet/dotnet-api-docs
@CarnaViire would you have the direct link to the api doc? I searched and searched without any results, that's how I ended up fixing it here 😂 |
@CarnaViire I was looking wrong, I have found the doc here, I'll send the PR there too https://github.com/dotnet/dotnet-api-docs/blob/c4ea6458ca24b6cf5c17292db5136a974fb3a5f7/xml/Microsoft.Extensions.Http.Logging/IHttpClientLogger.xml#L4 |
Updated remarks to provide the developer implementing this interface clearer documentation
Ok, I also fixed IHttpAsyncClientLogger.cs too and added the doc pr here dotnet/dotnet-api-docs#10653 but it seems here is the right place? |
Thanks!
Hmm.... Sorry for that. The process was changing back and forth over the last couple of years; I was under impression that the changes in the triple-slash docs don't sync automatically (only manually -- usually via bulk PRs), but maybe that was an outdated info. Anyway, let's go forward with that one and see if it syncs. |
Thanks @CarnaViire no worries I have updated the dotnet api docs before too so I also got confused 😂 |
/ba-g second reported issue is actually the same infra error ( |
Updated IHttpClientLogger remarks to provide clearer documentation to a developer implementing this interface
This PR pairs up with the doc api pr dotnet/dotnet-api-docs#10653