Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Update ApiCompatNetCoreAppBaselineVersion to 9.0.0 #109789

Merged

Conversation

carlossanlop
Copy link
Member

Fixes #106598
Follow up of #109316 (comment)

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member Author

@dotnet/dotnet-webassembly-admin @akoeplinger @lewing can you please take a look at the failure? Seems we will need additional changes in this PR related to wasm.

@akoeplinger
Copy link
Member

akoeplinger commented Nov 13, 2024

should be fixed now, mirrored the stable packages to dotnet-public

@carlossanlop carlossanlop merged commit 79043bb into dotnet:release/9.0-staging Nov 14, 2024
152 checks passed
@carlossanlop carlossanlop deleted the UpdateApiCompatBaseline branch November 14, 2024 21:00
@carlossanlop
Copy link
Member Author

carlossanlop commented Nov 14, 2024

should be fixed now, mirrored the stable packages to dotnet-public

Do we need to restart the CI in the main PR @akoeplinger ? #109790

@akoeplinger
Copy link
Member

Yes, but I agree with Viktor's comment in #109790 (comment) that we need to port #109316 too so you could put the change into that PR to restart CI.

@carlossanlop carlossanlop modified the milestones: 9.0.1, 9.0.2 Nov 21, 2024
@carlossanlop carlossanlop changed the title [release/9.0] Update ApiCompatNetCoreAppBaselineVersion to 9.0.0 [release/9.0-staging] Update ApiCompatNetCoreAppBaselineVersion to 9.0.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants