[release/9.0-staging] Fix regression in constructor parameter binding logic. #109813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
added
the
Servicing-consider
jeffhandley
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109786 to release/9.0-staging
/cc @eiriktsarpalis
Customer Impact
This was reported by a customer in #109768, reporting incorrect behavior when trying to deserialize JSON where there are two properties that differ in casing (e.g.
[JsonPropertyName("a")]and[JsonPropertyName("A")]).Regression
A refactoring introduced in 455f540 regressed the way in which conflicting parameters are being resolved. This reinstates the original logic.
Testing
Added unit testing covering the regressed case.
Risk
Low. Targeted change reinstating logic that got accidentally removed in .NET 9.