Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit full-path for loading MsQuic.dll on Windows #109963

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Use explicit full-path for loading MsQuic.dll on Windows #109963

merged 2 commits into from
Nov 20, 2024

Commits on Nov 19, 2024

  1. Use explicit full-path for loading MsQuic.dll on Windows

    @rzikm
    rzikm committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e8ae0bb View commit details
    Browse the repository at this point in the history

  2. Suppress IL3000 in MsQuicApi constructor 

    A call to `Assembly.Location` was added in a recent fix. It has `IL30000` suppressed via `#pragma warning disable`, but that only applies to the compilation of the library itself. Consumers will hit it when doing something like publishing their app as NativeAOT.

This change adds an `[UnconditionalSuppressMessage]` to the `MsQuicApi` static constructor such that `IL30000` should also be suppressed for apps consuming the runtime.

This was caught in an aspnetcore deps flow PR coming from runtime.
    @elinor-fung @rzikm
    elinor-fung authored and rzikm committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ae1737f View commit details
    Browse the repository at this point in the history