Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threads.h: Fix up grammar/spelling in vm/threads.h #109972

Merged

Conversation

bchavez
Copy link
Contributor

@bchavez bchavez commented Nov 19, 2024

Studying some internal CLR native NT thread handling related to DataDog/dd-trace-dotnet#6172 and came across this threads.h code comment that needed some grammar/spelling fix ups.

Thanks,
Brian

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 19, 2024
@am11
Copy link
Member

am11 commented Nov 19, 2024

I think most, if not all, instances reported by the following query can be updated:

git grep -i insur ':!src/native/external'
(i.e. search for case-insensitive 'insur' excluding everything under src/native/external directory)

@bchavez
Copy link
Contributor Author

bchavez commented Nov 19, 2024

Hi @am11, thanks for the review. I tried your command and got the following error:

image

However, I took the spirit of your command and ran it through rg/ripgrep:

rg -i insur --glob !src/native/external

and was able to get this commit be959e8 to replace other code comments with insur* -> ensur*.

And also rebased with latest on main.

Hope that helps

@bchavez bchavez force-pushed the threads-h-fixup-grammer-spelling-in-code-comments branch from be959e8 to ea1d155 Compare November 19, 2024 19:16
@am11
Copy link
Member

am11 commented Nov 19, 2024

I was on macOS zsh where single-quotes work (same as bash,powershell etc.). For command prompt, double-quotes would work git grep -i insur ":!src/native/external" (or no quotes since there is no space in that path segment)

Thanks for the update, LGTM!

@am11 am11 requested a review from jkotas November 19, 2024 19:34
@am11 am11 added area-Meta and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Nov 21, 2024

/ba-g Know issue #110008, Format jit codebase

@jkotas jkotas merged commit 25f9673 into dotnet:main Nov 21, 2024
163 of 169 checks passed
@jkotas
Copy link
Member

jkotas commented Nov 21, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants