Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge stack overflow handling helper stack #110068

Merged

Conversation

janvorli
Copy link
Member

The stack overflow coreclr tests started to fail recently. It turns out that was caused by the size of the helper stack allocated for stack overflow handling case is no longer sufficient. Moreover, there is a bug in Thread::CreateUtilityThread that calls the SetThreadName even when the thread creation fails.

Close #109499

The stack overflow coreclr tests started to fail recently. It turns out that
was caused by the size of the helper stack allocated for stack overflow
handling case is no longer sufficient. Moreover, there is a bug in
`Thread::CreateUtilityThread` that calls the `SetThreadName` even when the
thread creation fails.

Close dotnet#109499
@janvorli janvorli added this to the 10.0.0 milestone Nov 21, 2024
@janvorli janvorli requested a review from jkotas November 21, 2024 23:01
@janvorli janvorli self-assigned this Nov 21, 2024
@janvorli janvorli merged commit 1b85184 into dotnet:main Nov 22, 2024
90 checks passed
@janvorli janvorli deleted the enlarge-stack-overflow-handling-stack branch November 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd
2 participants