-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Add boolean field to indicate whether or not the Windows thread pool is being used #91246
Conversation
…adPool.Windows.cs Co-authored-by: Stephen Toub <[email protected]>
Tagging subscribers to this area: @mangod9 Issue DetailsBackport of #90551 to release/8.0 /cc @eduardo-vp Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@eduardo-vp is there a corresponding sos change coming to read this value? |
Yes, there's this one for the diagnostics repo dotnet/diagnostics#4160 and this one for the clrmd repo microsoft/clrmd#1175. I already tested the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can merge when ready
Backport of #90551 to release/8.0
/cc @eduardo-vp
Customer Impact
This field will be used by the
!threadpool
SOS command to allow customers debug applications using the Windows thread pool.Testing
The runtime correctly builds with no issues.
Risk
Very low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.