[release/8.0] [H/3] Fix draining response in metrics test #93381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #93379 to release/8.0 /cc @ManickaP Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
MihaZupan
approved these changes
Oct 12, 2023
karelz
approved these changes
Oct 12, 2023
antonfirsov
approved these changes
Oct 12, 2023
|
Test-only, we should take it to make CI more stable in 8.0 for servicing. @artl93 it is ready for your approval. |
carlossanlop
removed
the
Servicing-consider
|
Tell mode. Approving. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93379 to release/8.0
/cc @ManickaP
Customer Impact
This is just a test change. It will help stabilizing CI in 8.0 branch.
Testing
CI + local simulation of the problem with delay between sending response headers and content. After adding my fix, the test started passing with the delay as well.
Risk
Low, only test change, no product code change,
Fixes #93250