[Backport] Workload Clean for 8.0 Preview 3 #31411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Plaisted <[email protected]>
Co-authored-by: Daniel Plaisted <[email protected]>
…l feature bands instead of <=, and the error message.
…t does every band. Because we have v1 in the folder we can change the architecture based on that, instead of worrying about a future breaking change
…t clean and clean --all do
…lean. Include dotnetDir with newer info changes.
… with an if check instead of in the interface as it would be more confusing to have an msi api in a file based interface
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
nagilson
added
Area-Workloads
and removed
untriaged
dsplaisted
approved these changes
Mar 23, 2023
| [InlineData(false)] | ||
| public void GivenWorkloadCleanAllFileBasedItCleansAllFeatureBands(bool userLocal) | ||
| { | ||
| var (testDirectory, dotnetRoot, userProfileDir, workloadResolver, nugetDownloader) = Setup(userLocal, true); |
There was a problem hiding this comment.
Nit for future reference (I don't suggest changing this here, especially since it's in a dead-end release branch): It can be good for readability to specify the parameter names when passing in literals to a method.
Suggested change
| var (testDirectory, dotnetRoot, userProfileDir, workloadResolver, nugetDownloader) = Setup(userLocal, true); | |
| var (testDirectory, dotnetRoot, userProfileDir, workloadResolver, nugetDownloader) = Setup(userLocal, cleanAll: true); |
There was a problem hiding this comment.
Good to know, thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30266
Same code as that one.