Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] tool-update: Compare tool versions correctly #44517

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Oct 29, 2024

Addresses #43089 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2288480

When attempting to update a package to a new version, a check is made to ensure the same version is not installed twice. However, this check currently ignores the version suffix, which means users cannot update between versions with different release tags.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Oct 29, 2024
@edvilme edvilme marked this pull request as ready for review October 29, 2024 23:40
@edvilme edvilme requested a review from a team October 29, 2024 23:45
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Is it possible to add a test covering this case?

@edvilme edvilme requested a review from dsplaisted October 30, 2024 16:12
@edvilme edvilme merged commit 53c700e into dotnet:main Oct 31, 2024
37 checks passed
@v-sherryfan
Copy link

@dsplaisted Will this fix be backported to .NET 9.0? It still blocks NET9.0 updrage tooling scenario.

@dsplaisted
Copy link
Member

@marcpopMSFT Can we consider this for 9.0 servicing? If not, we should at least put it in 9.0.200 I think.

@baronfel
Copy link
Member

baronfel commented Nov 5, 2024

Would +1 backporting this.

@marcpopMSFT
Copy link
Member

Yeah, seems like it's broken for every prerelease version. I don't know how common that is for tools but seems like a pretty critical scenario. Do we know when it broke though? edvilme indicated it's been this way for a while. If a while, then 9.0.2xx. If recent, 9.0.1xx.

@edvilme
Copy link
Member Author

edvilme commented Nov 5, 2024

Just checked again and it seems this behavior was introduced in #41746 on June so it would be relatively recent (I wrongly remembered it was from a lot of time ago)

@marcpopMSFT
Copy link
Member

That makes it a regression in 9 so I'd support porting to 9.0.101.

@edvilme
Copy link
Member Author

edvilme commented Dec 9, 2024

/backport to release/9.0.1xx

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/12241074698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants