-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] tool-update: Compare tool versions correctly #44517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix! Is it possible to add a test covering this case?
test/dotnet.Tests/CommandTests/ToolUpdateGlobalOrToolPathCommandTests.cs
Outdated
Show resolved
Hide resolved
@dsplaisted Will this fix be backported to .NET 9.0? It still blocks NET9.0 updrage tooling scenario. |
@marcpopMSFT Can we consider this for 9.0 servicing? If not, we should at least put it in 9.0.200 I think. |
Would +1 backporting this. |
Yeah, seems like it's broken for every prerelease version. I don't know how common that is for tools but seems like a pretty critical scenario. Do we know when it broke though? edvilme indicated it's been this way for a while. If a while, then 9.0.2xx. If recent, 9.0.1xx. |
Just checked again and it seems this behavior was introduced in #41746 on June so it would be relatively recent (I wrongly remembered it was from a lot of time ago) |
That makes it a regression in 9 so I'd support porting to 9.0.101. |
/backport to release/9.0.1xx |
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/12241074698 |
Addresses #43089 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2288480
When attempting to update a package to a new version, a check is made to ensure the same version is not installed twice. However, this check currently ignores the version suffix, which means users cannot update between versions with different release tags.