Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for MSBuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language #44927

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Workaround for MSBuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language #44927

merged 3 commits into from
Nov 20, 2024
+78 −3

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 18, 2024 •
edited
Loading

Implements workaround for dotnet/roslyn#75956.

Fixes #44908

@tmat tmat requested a review from a team as a code owner November 18, 2024 17:24
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Nov 18, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat tmat changed the title Workaround for MSbuildProjectLoader.LoadProjectInfoAsync on unrecognized project language Workaround for MSbuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language Nov 18, 2024
@tmat tmat changed the title Workaround for MSbuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language Workaround for MSBuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language Nov 18, 2024
@tmat tmat mentioned this pull request Nov 18, 2024
Open
This was referenced Nov 18, 2024
Open
Open
@tmat tmat enabled auto-merge (squash) November 19, 2024 21:40
@build-analysis build-analysis bot mentioned this pull request Nov 19, 2024
Open
@tmat tmat merged commit 4f0bcf1 into dotnet:release/9.0.2xx Nov 20, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-allen-msft phil-allen-msft phil-allen-msft approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @jasonmalinowski @phil-allen-msft