Refactor Analyzer tests. #12822
Draft
Refactor Analyzer tests. #12822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
....Analyzers.CSharp/tests/UnitTests/Analyzers/AvoidPassingTaskWithoutCancellationTokenTests.cs
Outdated
Show resolved
Hide resolved
| @@ -34,4 +34,22 @@ | |||
| </None> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Remove="TestData\AvoidPassingTaskWithoutCancellationToken\AnalyzerTestCode.cs" /> | |||
There was a problem hiding this comment.
How about calling this directory Data instead of TestData?
KlausLoeffelmann
force-pushed
the
RefactorAnalyzerTests
branch
from
699ded6 to
fb2433a
Compare
| using Microsoft.CodeAnalysis.CSharp.Testing; | ||
| using Microsoft.CodeAnalysis.Testing; | ||
|
|
||
| namespace System.Windows.Forms.Analyzers.Test; |
There was a problem hiding this comment.
@KlausLoeffelmann - please unify namespace names
Suggested change
| namespace System.Windows.Forms.Analyzers.Test; | |
| namespace System.Windows.Forms.Analyzers.Tests; |
KlausLoeffelmann
force-pushed
the
RefactorAnalyzerTests
branch
from
ea74bd4 to
e47aa99
Compare
| // completion list within the designer repo because of a C# editor feature that always | ||
| // shows symbols defined in source, regardless of EditorBrowsableState. | ||
|
|
||
| [EditorBrowsable(EditorBrowsableState.Never)] |
There was a problem hiding this comment.
This is not relevant in the runtime
KlausLoeffelmann
force-pushed
the
RefactorAnalyzerTests
branch
from
7917c27 to
7bec660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're expecting more Analyzers in the WinForms area coming also as community contribution, it makes sense to simplify and standardize the tests we have for Analyzers and CodeFixes.
This PR does the first step in that direction by doing a first refactoring pass of the Analyzer/CodeFixes tests.
Microsoft Reviewers: Open in CodeFlow