Fix internal build break #12901
Open
Fix internal build break #12901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s started to fail on th epublising stage. https://dev.azure.com/dnceng/internal/_build/results?buildId=2637287&view=results This stage reads the "BAR manifests" - a list of our nuget packages that looks like this <Package Id="Microsoft.Dotnet.WinForms.ProjectTemplates" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> <Package Id="Microsoft.Private.Winforms" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> <Package Id="System.Drawing.Common" Version="10.0.0-preview.2.25106.1" DotNetReleaseShipping="true" Visibility="External"/> <Package Id="System.Private.Windows.Core.TestUtilities" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> "BAR manifest" is generated on the "Pack Sign and Publish" step. Before the PR from arcade, this step was generating manifest named AssetManifest\Windows_NT-AnyCPU.xml for each architecture, overriding the previously written one inplace. Then the publish step was processeng that manifest. After the arcade PR we are generating 3 manifests, one for each architecture. Windows_Arm64.xml Windows_x64.xml Windows_x86.xml probably because of this change dotnet/arcade@232c628 We need only a single manifest and a single set of the nugets, thus we should run the publishing step only for x64. I don't know why build-PR script has the "Pack, Sign. publish" step because it does not actually run "Skipping step due to condition evaluation." I think this step can only run in AzDO (looking at publish.proj in arcade) I'm open to removing this step.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12901 +/- ##
===================================================
- Coverage 76.08079% 76.07721% -0.00358%
===================================================
Files 3257 3257
Lines 642145 642145
Branches 47286 47286
===================================================
- Hits 488549 488526 -23
- Misses 150037 150074 +37
+ Partials 3559 3545 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
ViktorHofer
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a dependency flow PR from arcade #12873 our internal builds started to fail on the publising stage. https://dev.azure.com/dnceng/internal/_build/results?buildId=2637287&view=results
This stage reads the "BAR manifest" - a list of our nuget packages that looks like this:
"BAR manifest" is generated on the "Pack Sign and Publish" step. Before the PR from arcade, this step was generating manifest named
AssetManifest\Windows_NT-AnyCPU.xmlfor each architecture, overriding the previously written one in place. Then the publish step would process that manifest. After the arcade PR we are generating 3 manifests, one for each architecture.Windows_Arm64.xml
Windows_x64.xml
Windows_x86.xml
probably because of this change dotnet/arcade@232c628
We need only a single manifest and a single set of the nugets, thus we should run the publishing step only for x64.
I don't know why build-PR script has the "Pack, Sign. publish" step because it does not actually run ("Skipping step due to condition evaluation.") I think this step can only run in AzDO (looking at publish.proj in arcade) I'm open to removing this step.
test run https://dev.azure.com/dnceng/internal/_build/results?buildId=2638049&view=results
Microsoft Reviewers: Open in CodeFlow