Fix Indeterminate Progress Bar animation with CacheMode set up #10649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
h3xds1nz
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10649 +/- ##
===================================================
+ Coverage 11.22814% 11.25824% +0.03010%
===================================================
Files 3352 3353 +1
Lines 668000 668062 +62
Branches 74980 74980
===================================================
+ Hits 75004 75212 +208
+ Misses 591745 591604 -141
+ Partials 1251 1246 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| // However, we can only allow ourselves to do that if the ProgressBar is not being cached, since when the UIElement is defined within | ||
| // resources, IsVisible property will always evaluate to false as the UIElement is not a part of the visual tree at that point. (#8960) | ||
|
|
||
| if (!IsIndeterminate || (!IsVisible && CacheMode is null)) |
There was a problem hiding this comment.
Wouldn't it be better to check if the ProgressBar is part of the visual tree instead of checking CacheMode ?
Something like this:
Suggested change
| if (!IsIndeterminate || (!IsVisible && CacheMode is null)) | |
| if (!IsIndeterminate || (!IsVisible && VisualTreeHelper.GetParent(this) is not null)) |
I haven't tested it but to me it's more precise because the bug does not seem specific to `CacheMode`.
There was a problem hiding this comment.
@ThomasGoulet73 Maybe I scoped too narrowly, I'll check this but imho should work indeed.
h3xds1nz
added
regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8960
Description
Adjusts the logic behind transitioning to
Determinatestate to avoid background animation to exclude a case when aCacheModeis set up on theProgressBarand theProgressBaris not a part of the visual tree (IsVisibleevaluates tofalse).It is worth nothing that the pre-NET 7.0 behaviour would work even without explicit
CacheModeset-up. This basically provides a middle ground for the solution used commonly in applications, where explicitly setting upCacheModesolves the immediate issue but if you had only used the resource as a target ofBitmapCacheBrush, it will not work (which seems alright though).Imho that is an acceptable behavioral change from pre-NET7.0 behaviour and should be documented accordingly.
Customer Impact
If this change is not taken, customers will not be able to cache their indeterminate progress bars as they used to be.
Regression
Yeah, broken in #6266.
Testing
Local build, repro in #8960 and #6264.
Risk
Medium, we should have more test cases covering these kinda changes.
Microsoft Reviewers: Open in CodeFlow