Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ArrayList from CompositionAdorner with List<AttributeRange> #10673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 29, 2025

Description

Replaces ArrayList with List<AttributeRange> to increase type safety and promote strongly-typed code. Most of the perf benefits beyond t0 were now erased in post .NET 9 as the ArrayList methods are usually successfully de-abstracted but that doesn't really matter as its still a benefit to use a generic collection type instead e.g. to bypass cast checks.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

Low, just a type swap on private collection.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 29, 2025 14:21
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 29, 2025
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 11.25415%. Comparing base (6514196) to head (76a29bf).
Report is 11 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10673         +/-   ##
===================================================
+ Coverage   11.22814%   11.25415%   +0.02600%     
===================================================
  Files           3352        3353          +1     
  Lines         668000      668056         +56     
  Branches       74980       74979          -1     
===================================================
+ Hits           75004       75184        +180     
+ Misses        591745      591624        -121     
+ Partials        1251        1248          -3     
Flag Coverage Δ
Debug 11.25415% <0.00000%> (+0.02600%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant