-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove Critical/Unsecure property/method proxies and CAS-related code #10701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
h3xds1nz
wants to merge
36
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:unsecure-critical
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+534
−1,384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10701 +/- ##
===================================================
+ Coverage 10.95887% 11.06411% +0.10524%
===================================================
Files 3310 3310
Lines 664667 664464 -203
Branches 74667 74653 -14
===================================================
+ Hits 72840 73517 +677
+ Misses 590685 589809 -876
+ Partials 1142 1138 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slowly coming to an end, but an additional batch of CAS-related obsolete / dead code, this time the "Critical" and "Unsecure" proxies and demand methods that do nothing these days. That includes all bunch of security notes and other comments.
It is mostly scoped commit by commit to make the review as smooth as possible besides
CriticalFromVisual
where the fixer wasn't kind to me and I've noticed way too late, so hopefully all issues are fixed in the latest commut.Code that I've removed in previous PRs already is untouched (though it ain't extra nice to keep hitting the same code 6 months later, not gonna lie). But after all these things are merged, it should be clean finally. Maybe 1 exception string.
Customer Impact
Cleaner codebase for developers, a bit of perf in some cases.
Regression
No.
Testing
Local build, sample app run.
Risk
Should be low, it is mostly just renames and some removals/code moves.
Microsoft Reviewers: Open in CodeFlow