Fix ArgumentException with FromWidth/Height options in InteropBitmap #10706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10397
Description
Fixes an
ArgumentException
that would occur in any case the sizing options passed would be created viaFromHeight
andFromWidth
factory methods due to invalid arguments passed toGetScaledWidthAndHeight
(self).Instead the correct values to pass are the source bitmap dimensions. In case there's no clip rect provided, we must retrieve the width/height as we don't have it yet available during initialization, otherwise pass the clip rect.
Customer Impact
Customers will be able to scale
InteropBitmap
without any exceptions upon creation.Regression
It is the case in NetFX as well.
Testing
Tests are included.
Risk
Low, from non-working to working properly.
Microsoft Reviewers: Open in CodeFlow