Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracked inference logic to inferredResultType #53

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

mbovel
Copy link
Collaborator

@mbovel mbovel commented Nov 1, 2024

No description provided.

@mbovel mbovel force-pushed the mb/abstract-tracked-namer branch from 600859a to 28b5725 Compare November 1, 2024 14:41
@mbovel

This comment was marked as outdated.

@mbovel
Copy link
Collaborator Author

mbovel commented Nov 3, 2024

I gave this another shot and tried to move the logic to inferredResultType. This makes the precise inference of tracked members work in a similar way to the precise inference of inline vals.

@mbovel mbovel changed the title Move setAbstractTrackedInfo to Namer.Completer Move tracked inference logic to inferredResultType Nov 3, 2024
@KacperFKorban
Copy link
Member

@mbovel I propose that we merge this PR and ask for Martin's approval on scala#21761, since this approach is objectively better.

@mbovel
Copy link
Collaborator Author

mbovel commented Nov 11, 2024

Sounds good to me!

@KacperFKorban KacperFKorban merged commit b15153e into abstract-tracked Nov 11, 2024
11 of 12 checks passed
@KacperFKorban KacperFKorban deleted the mb/abstract-tracked-namer branch November 11, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants