added controller specs #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compwron I fixed the failing tests |
fchatterji
changed the title
|
@compwron I had more time on this, so I improved the tests for the admin controller. Please tell me if that looks good to you, if it does i propose merging this PR, and when i have time i'll do another one for the other controllers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #453
What does this code do, and why?
added some specs for comments controller
added specs to the admin controller
removed duplicated simplecov config in rails bin
improved simplecov config in spec helper to add coverage groups (models, controllers...)
How is this code tested?
Are any database migrations required by this change?
no
Are there any configuration or environment changes needed?
no
Screenshots please :)