Merge pull request #301 from dpaulat/hotfix/layer_model_mime_data

Validate parent row before dropping mime data in LayerModel
dpaulat · Nov 26, 2024 · 694d322 · 694d322
2 parents 4a66715 + 756249c
commit 694d322
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/scwx-qt/source/scwx/qt/model/layer_model.cpp b/scwx-qt/source/scwx/qt/model/layer_model.cpp
@@ -774,6 +774,13 @@ bool LayerModel::dropMimeData(const QMimeData* data,
    QDataStream      stream(&mimeData, QIODevice::ReadOnly);
    std::vector<int> sourceRows {};
 
+   // Validate parent row
+   if (parent.row() < 0 || parent.row() >= static_cast<int>(p->layers_.size()))
+   {
+      logger_->warn("Cannot perform drop action, invalid parent row");
+      return false;
+   }
+
    // Read source rows from QMimeData
    while (!stream.atEnd())
    {