Fix preemptive initialization because of clang-tidy changes

dpaulat · Dec 14, 2024 · c511ad6 · c511ad6
1 parent bed7989
commit c511ad6
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/scwx-qt/source/scwx/qt/ui/edit_marker_dialog.cpp b/scwx-qt/source/scwx/qt/ui/edit_marker_dialog.cpp
@@ -30,12 +30,7 @@ static const auto        logger_    = scwx::util::Logger::Create(logPrefix_);
 class EditMarkerDialog::Impl
 {
 public:
-   explicit Impl(EditMarkerDialog* self) :
-       self_ {self},
-       deleteButton_ {self_->ui->buttonBox->addButton(
-          "Delete", QDialogButtonBox::DestructiveRole)}
-   {
-   }
+   explicit Impl(EditMarkerDialog* self) : self_ {self} {}
 
    void show_color_dialog();
    void show_icon_file_dialog();
@@ -48,7 +43,7 @@ class EditMarkerDialog::Impl
    void handle_rejected();
 
    EditMarkerDialog* self_;
-   QPushButton*      deleteButton_;
+   QPushButton*      deleteButton_ {nullptr};
    QIcon             get_colored_icon(const types::MarkerIconInfo& marker,
                                       const std::string&           color);
 
@@ -80,6 +75,8 @@ EditMarkerDialog::EditMarkerDialog(QWidget* parent) :
                                 QString(""),
                                 QString::fromStdString(markerIcon.second.name));
    }
+   p->deleteButton_ =
+      ui->buttonBox->addButton("Delete", QDialogButtonBox::DestructiveRole);
    p->connect_signals();
 }