Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang Checks #304

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Clang Checks #304

merged 9 commits into from
Nov 28, 2024

Conversation

dpaulat
Copy link
Owner

@dpaulat dpaulat commented Nov 28, 2024

  1. Changed files will undergo a format check. Visual Studio and Visual Studio Code should both format according to the same .clang-format set of rules that the job uses to check.
  2. Changed lines will undergo a clang-tidy check. The rules are defined in a .clang-tidy file. I suspect I'll end up filtering out a couple additional checks, I attempted to take a first stab already. If the linter is incorrectly flagging something, a NOLINT comment can be applied (see clang-tidy docs).
    • The NOLINT should suppress ONLY the specific rule, and
    • include a note on why the lint check can be ignored or shouldn't be linted
    • The clang-tidy results will be added to the pull request as comments (up to 25). Anything over 25 will be available in a subsequent run, or as a json artifact from the job.
    • You can accept suggestions straight from the pull request too, even batch them from the file review tab.

@dpaulat dpaulat merged commit f2e1db4 into develop Nov 28, 2024
5 checks passed
@dpaulat dpaulat deleted the feature/clang-checks branch November 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant