Change negative threshold values to act as inverted threshold #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaulat
approved these changes
Dec 10, 2024
| @@ -136,7 +136,11 @@ void PlacefileText::Impl::RenderTextDrawItem( | |||
| std::chrono::system_clock::now() : | |||
| selectedTime_; | |||
|
|
|||
| if ((!thresholded_ || mapDistance_ <= di->threshold_) && | |||
| const bool thresholdMet = | |||
There was a problem hiding this comment.
Consider adding !thresholded_ to the front of this check, to optimize and skip performing evaluation when not thresholding.
| if ((!thresholded_ || mapDistance_ <= di->threshold_) && | ||
| const bool thresholdMet = | ||
| mapDistance_ <= di->threshold_ || | ||
| ((double) di->threshold_ < 0.0 && mapDistance_ >= -(di->threshold_)); |
There was a problem hiding this comment.
Style: recommend static_cast(value) over C-style cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is not a change you want to make, I am fine with that. It was a small change I was interested in, and I want your opinion on it.
Inverted threshold means that once you zoom in past that threshold, it disrepair. This is useful for placefiles that give low detail, nation wide information, such as surface fronts.
Breaking Compatibility
I do not believe this will break compatibility with placefiles or other programs. If any placefile does use negative numbers to disable threshold's, the user can disable thresholds in Supercell Wx. The only case this would not work is if a placefile sometimes has thresholds, and sometimes uses negative numbers to disable thresholds. If other programs act as Supercell Wx did before this change, then any placefile with negative threshold will simply not have a threshold.