Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radar Smoothing #322

Merged
merged 33 commits into from
Dec 16, 2024
Merged

Radar Smoothing #322

merged 33 commits into from
Dec 16, 2024

Conversation

dpaulat
Copy link
Owner

@dpaulat dpaulat commented Dec 15, 2024

No description provided.

dpaulat added 29 commits December 1, 2024 00:37
@dpaulat
Refactoring Level2ProductViewImpl to Level2ProductView::Impl
13a015c
@dpaulat
Compute smoothed coordinates
84f0003
@dpaulat
Update vertices for smoothing
1c8d7f5
@dpaulat
Begin logic for smoothed data moment values
1ac85e2
@dpaulat
Update smoothing data moment calculations
608b1af
@dpaulat
Fix iterator advancement
5be8d7b
@dpaulat
Get rid of white/max reflectivity bins due to unsigned integer underflow
e93697b
@dpaulat
Clean up smoothed data moment population
80d5be9
@dpaulat
Data moments should not have GLSL flat qualifiers to be sampled more …
1b07c6f 
…than once per triangle
@dpaulat
The last smoothed radial needs the first radial to render
a5919ac
@dpaulat
An extra empty radial is still needed for incomplete data when smoothing
e0cd361
@dpaulat
Delta angles must be normalized before they can be scaled
d3ae404
@dpaulat
Allow selection of radar smoothing
a8132ef
@dpaulat
Add pre-caluclated smoothed coordinates
9f7026b
@dpaulat
Level 3 radial product smoothing
57f6b41
@dpaulat
Merge branch 'develop' into feature/radar-smoothing
b93c76e
@dpaulat
Level 3 raster smoothing
44f91a3
@dpaulat
Fix integer comparison signedness
40149ae
@dpaulat
Fix level 2 16-bit data moment references
ac48ac2
@dpaulat
Perform level 2 data moment remapping when smoothing
c492f11
@dpaulat
Perform level 3 data moment remapping when smoothing
b7970bb
@dpaulat
Merge branch 'develop' into feature/radar-smoothing
82ea0da
@dpaulat
Fix 1 degree smooth coordinates location
172203e
@dpaulat
Add smoothing settings
3e681ab
@dpaulat
Toggle for smoothed range folding in settings dialog
77e02b7
@dpaulat
Add radar wireframe debug menu selection
f010ea8
@dpaulat
Save radar smoothing state in settings
cc0ebcd
@dpaulat
Disable range folding display by default when smoothing
a65504a
@dpaulat
Linting fixes
57b773d
github-actions[bot]
github-actions bot reviewed Dec 15, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 41. Check the log or trigger a new build to see more.

scwx-qt/source/scwx/qt/main/main_window.cpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/main/main_window.cpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/manager/radar_product_manager.hpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/map/map_settings.hpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/map/map_widget.hpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/view/level2_product_view.cpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/view/level2_product_view.cpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/view/level2_product_view.cpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/view/level2_product_view.cpp Outdated Show resolved Hide resolved
scwx-qt/source/scwx/qt/view/level2_product_view.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Dec 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

scwx-qt/source/scwx/qt/view/level2_product_view.cpp Outdated Show resolved Hide resolved
@dpaulat dpaulat merged commit bef8628 into develop Dec 16, 2024
5 checks passed
@dpaulat dpaulat deleted the feature/radar-smoothing branch December 16, 2024 14:18
@dpaulat dpaulat linked an issue Jan 5, 2025 that may be closed by this pull request
Radar Smoothing - Feature #249
Closed
@dpaulat dpaulat mentioned this pull request Jan 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radar Smoothing - Feature
1 participant
@dpaulat