Merged PR 2661: unit tests fixed - some sensors still need work

Related work items: #11865
dqops · May 17, 2024 · 68a6a88 · 68a6a88
2 parents 31ea9d2 + 8938597
commit 68a6a88
Show file tree

Hide file tree

Showing 102 changed files with 1,234 additions and 2,137 deletions.
diff --git a/...tedvalues/ColumnAcceptedValuesTextFoundInSetPercentSensorParametersSpecBigQueryTests.java b/...tedvalues/ColumnAcceptedValuesTextFoundInSetPercentSensorParametersSpecBigQueryTests.java
@@ -150,7 +150,7 @@ void renderSensor_whenProfilingNoTimeSeriesNoDataStreamNoValuesList_thenRendersC
         String renderedTemplate = JinjaTemplateRenderServiceObjectMother.renderBuiltInTemplate(runParameters);
         String target_query = """
             SELECT
-                0.0 AS actual_value
+                MAX(0.0) AS actual_value
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s""";
 
@@ -220,13 +220,9 @@ WHEN COUNT(%s) = 0 THEN 100.0
                             ELSE 0
                         END
                     ) / COUNT(%s)
-                END AS actual_value,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                END AS actual_value
             FROM `%s`.`%s`.`%s` AS analyzed_table
-            WHERE %s
-            GROUP BY time_period, time_period_utc
-            ORDER BY time_period, time_period_utc""";
+            WHERE %s""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -338,13 +334,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
                         END
                     ) / COUNT(%s)
                 END AS actual_value,
-                analyzed_table.`length_int` AS grouping_level_1,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_int` AS grouping_level_1
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, time_period, time_period_utc
-            ORDER BY grouping_level_1, time_period, time_period_utc""";
+            GROUP BY grouping_level_1
+            ORDER BY grouping_level_1""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -474,13 +468,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
                 END AS actual_value,
                 analyzed_table.`strings_with_numbers` AS grouping_level_1,
                 analyzed_table.`mix_of_values` AS grouping_level_2,
-                analyzed_table.`length_int` AS grouping_level_3,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_int` AS grouping_level_3
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
-            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
+            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
+            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),

diff --git a/...ceptedvalues/ColumnNumericExpectedNumbersInUseCountSensorParametersSpecBigQueryTests.java b/...ceptedvalues/ColumnNumericExpectedNumbersInUseCountSensorParametersSpecBigQueryTests.java
@@ -212,13 +212,9 @@ void renderSensor_whenMonitoringDefaultTimeSeriesNoDataStream_thenRendersCorrect
                         ELSE NULL
                     END
                 ) AS actual_value,
-                MAX(3) AS expected_value,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                MAX(3) AS expected_value
             FROM `%s`.`%s`.`%s` AS analyzed_table
-            WHERE %s
-            GROUP BY time_period, time_period_utc
-            ORDER BY time_period, time_period_utc""";
+            WHERE %s""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -321,13 +317,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
                     END
                 ) AS actual_value,
                 MAX(3) AS expected_value,
-                analyzed_table.`length_string` AS grouping_level_1,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_string` AS grouping_level_1
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, time_period, time_period_utc
-            ORDER BY grouping_level_1, time_period, time_period_utc""";
+            GROUP BY grouping_level_1
+            ORDER BY grouping_level_1""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -448,13 +442,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
                 MAX(3) AS expected_value,
                 analyzed_table.`strings_with_numbers` AS grouping_level_1,
                 analyzed_table.`mix_of_values` AS grouping_level_2,
-                analyzed_table.`length_string` AS grouping_level_3,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_string` AS grouping_level_3
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
-            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
+            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
+            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),

diff --git a/...acceptedvalues/ColumnNumericNumberFoundInSetPercentSensorParametersSpecBigQueryTests.java b/...acceptedvalues/ColumnNumericNumberFoundInSetPercentSensorParametersSpecBigQueryTests.java
@@ -149,7 +149,7 @@ void renderSensor_whenProfilingNoTimeSeriesNoDataStreamNoValuesList_thenRendersC
         String renderedTemplate = JinjaTemplateRenderServiceObjectMother.renderBuiltInTemplate(runParameters);
         String target_query = """
             SELECT
-                0.0 AS actual_value
+                MAX(0.0) AS actual_value
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s""";
 
@@ -219,13 +219,9 @@ WHEN COUNT(%s) = 0 THEN 100.0
                             ELSE 0
                         END
                     ) / COUNT(%s)
-                END AS actual_value,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                END AS actual_value
             FROM `%s`.`%s`.`%s` AS analyzed_table
-            WHERE %s
-            GROUP BY time_period, time_period_utc
-            ORDER BY time_period, time_period_utc""";
+            WHERE %s""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -337,13 +333,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
                         END
                     ) / COUNT(%s)
                 END AS actual_value,
-                analyzed_table.`length_string` AS grouping_level_1,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_string` AS grouping_level_1
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, time_period, time_period_utc
-            ORDER BY grouping_level_1, time_period, time_period_utc""";
+            GROUP BY grouping_level_1
+            ORDER BY grouping_level_1""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -473,13 +467,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
                 END AS actual_value,
                 analyzed_table.`strings_with_numbers` AS grouping_level_1,
                 analyzed_table.`mix_of_values` AS grouping_level_2,
-                analyzed_table.`length_string` AS grouping_level_3,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_string` AS grouping_level_3
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
-            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
+            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
+            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),

diff --git a/...tedvalues/ColumnStringsExpectedTextValuesInUseCountSensorParametersSpecBigQueryTests.java b/...tedvalues/ColumnStringsExpectedTextValuesInUseCountSensorParametersSpecBigQueryTests.java
@@ -213,13 +213,9 @@ void renderSensor_whenMonitoringDefaultTimeSeriesNoDataStream_thenRendersCorrect
                         ELSE NULL
                     END
                 ) AS actual_value,
-                MAX(3) AS expected_value,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                MAX(3) AS expected_value
             FROM `%s`.`%s`.`%s` AS analyzed_table
-            WHERE %s
-            GROUP BY time_period, time_period_utc
-            ORDER BY time_period, time_period_utc""";
+            WHERE %s""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -322,13 +318,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
                     END
                 ) AS actual_value,
                 MAX(3) AS expected_value,
-                analyzed_table.`length_int` AS grouping_level_1,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_int` AS grouping_level_1
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, time_period, time_period_utc
-            ORDER BY grouping_level_1, time_period, time_period_utc""";
+            GROUP BY grouping_level_1
+            ORDER BY grouping_level_1""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),
@@ -449,13 +443,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
                 MAX(3) AS expected_value,
                 analyzed_table.`strings_with_numbers` AS grouping_level_1,
                 analyzed_table.`mix_of_values` AS grouping_level_2,
-                analyzed_table.`length_int` AS grouping_level_3,
-                DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
-                TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
+                analyzed_table.`length_int` AS grouping_level_3
             FROM `%s`.`%s`.`%s` AS analyzed_table
             WHERE %s
-            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
-            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
+            GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
+            ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
 
         Assertions.assertEquals(String.format(target_query,
                 this.getTableColumnName(runParameters),