-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qpoasse_interface test] PR added check for equality constraints #18
Conversation
Hi @qlin960618, as mentioned in PR1, the cpp-interface-qpoases you are proposing is not running with the current example. I'll wait for your reply to review this PR. Please note that your commit messages are not following the DQ Robotics convention, which is summarized in CONTRIBUTING.md. Please update your messages in newer commits.
Best regards, Juan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qlin960618 Thank you for your PR. There are some minor modifications.
@mmmarinho This PR is ready for your review. |
@juanjqo Are all points of discussion resolved? Can I mark them as resolved if you're unable to do so? |
@mmmarinho Yes, all points were resolved. I am not allowed to mark them as resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanjqo Seems fine. I'll proceed with the merge and let me know if something goes wrong.
Hi @mmmarinho,
This PR added test for the DQ_QPOASESSolver equality constraints check that is in tandem with the PR #1 in that Repo.
Some modification were made to the original code limited to the structure, in addition to a new
test_equality
test case.qlin
Best,