Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter syntax and errors #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harkabeeparolus
Copy link

I fixed some syntax errors, ran ShellCheck, and cleaned up the code a little.

@ethancedwards8
Copy link
Member

We're always looking for code improvements! Thank you. Could you rerun everything on the current code base?

@harkabeeparolus
Copy link
Author

We're always looking for code improvements! Thank you. Could you rerun everything on the current code base?

Sure, I'm happy to help, and I'm an experienced bash developer. Would you like me to clean up the whole scripts directory while I'm at it? I noticed that ShellCheck finds more errors and warnings. And in general I find that ShellCheck and Shellharden do the right thing, making bash code more robust.

@ethancedwards8
Copy link
Member

Sure. That would be great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants